Add qdrant native engine #271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new qdrant_native engine that communicates with Qdrant using the REST API directly via httpx, as an alternative to the existing qdrant engine that uses the official Qdrant Python client. The implementation provides native HTTP-based access for benchmarking purposes.
- Adds a complete qdrant_native engine implementation with configuration, upload, search, and parsing capabilities
- Integrates the new engine into the client factory
- Provides configuration presets for single-node benchmarking scenarios
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| experiments/configurations/qdrant-native-single-node.json | Adds 8 benchmark configuration presets for the qdrant_native engine with varying quantization and search parameters |
| engine/clients/qdrant_native/init.py | Module initialization exposing configurator, uploader, and searcher classes |
| engine/clients/qdrant_native/config.py | Configuration constants for collection name and API key from environment variables |
| engine/clients/qdrant_native/configure.py | Collection configuration and creation logic using REST API |
| engine/clients/qdrant_native/parser.py | Filter condition parser converting internal format to Qdrant REST API JSON |
| engine/clients/qdrant_native/search.py | Search implementation using httpx for direct REST API queries |
| engine/clients/qdrant_native/upload.py | Upload implementation with batch processing and post-upload optimization handling |
| engine/clients/client_factory.py | Registers qdrant_native engine in factory mappings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This facilitates benchmarking of those changes in the core, that require python-client update. Qdrant "native" engine calls Rest APIs directly.